| Summary: | AX: support clickPoint in DRT for chromium | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||||||||||
| Component: | Accessibility | Assignee: | Dominic Mazzoni <dmazzoni> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | abarth, apinheiro, dglazkov, dmazzoni, fishd, jamesr, jdiggs, jochen, loislo, tkent+wkapi, tony, webkit.review.bot | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
chris fleizach
2012-09-21 13:44:08 PDT
Created attachment 179810 [details]
Patch
Comment on attachment 179810 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179810&action=review > Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:742 > + if (arguments.size() != 2 || !arguments[0].isNumber() || !arguments[1].isNumber()) { you could set result->setNull() at the top and then be able to just return on the failure case here and... > Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:752 > + result->setNull(); here Created attachment 179825 [details]
Patch for landing
Comment on attachment 179825 [details] Patch for landing Rejecting attachment 179825 [details] from commit-queue. New failing tests: accessibility/svg-bounds.html accessibility/svg-remote-element.html Full output: http://queues.webkit.org/results/15377906 Created attachment 179991 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Created attachment 179995 [details]
Patch
OK, I made a few more changes so there aren't any platform-specific differences in the test expectations - take another quick look? Comment on attachment 179995 [details]
Patch
WebKit API changes LGTM
Comment on attachment 179995 [details] Patch Clearing flags on attachment: 179995 Committed r138061: <http://trac.webkit.org/changeset/138061> All reviewed patches have been landed. Closing bug. Reverted r138061 for reason: It is crashing on Debug bots Committed r138121: <http://trac.webkit.org/changeset/138121> (In reply to comment #12) > Reverted r138061 for reason: > > It is crashing on Debug bots > > Committed r138121: <http://trac.webkit.org/changeset/138121> This bug was also opened https://bugs.webkit.org/show_bug.cgi?id=105372 Created attachment 180266 [details]
Patch
The problem was that we were calling a method to retrieve the bounding rect of an SVG object that wasn't taking transformations into account, and this triggered an assertion failure in debug mode on Chromium. It seems like this fix should be safe, the focus rect logic shouldn't ever be needed for an SVG object. Comment on attachment 180266 [details] Patch can you also undo this change http://trac.webkit.org/changeset/138094 Comment on attachment 180266 [details] Patch Clearing flags on attachment: 180266 Committed r138260: <http://trac.webkit.org/changeset/138260> All reviewed patches have been landed. Closing bug. accessibility/svg-remote-element.html appears to be timing out on the Chromium debug bots. Should I mark this test as slow? http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=accessibility%2Fsvg-remote-element.html It's not slow. I think it's flakiness, I filed a new bug for it and I think I know what the issue might be: https://bugs.webkit.org/show_bug.cgi?id=105587 |