Bug 97353

Summary: Split stylesheet related code out from Document
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dbarton, dglazkov, eric, gyuyoung.kim, kling, macpherson, menard, peter+ews, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
eric: review-, webkit-ews: commit-queue-
try to make it build
none
update to tot
none
another try
none
another rebase kling: review+

Antti Koivisto
Reported 2012-09-21 11:59:00 PDT
Document is big and unwieldy. The code related to tracking active stylesheets can be factored out.
Attachments
patch (103.47 KB, patch)
2012-09-22 22:33 PDT, Antti Koivisto 		eric: review-
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
try to make it build (528.76 KB, patch)
2012-09-24 11:46 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
update to tot (528.66 KB, patch)
2012-09-24 12:03 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
another try (528.54 KB, patch)
2012-09-24 12:16 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
another rebase (528.91 KB, patch)
2012-09-24 13:57 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-09-22 22:33:57 PDT
Created attachment 165278 [details] patch
Early Warning System Bot
Comment 2 2012-09-22 22:55:08 PDT
Comment on attachment 165278 [details] patch Attachment 165278 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13988234
Gyuyoung Kim
Comment 3 2012-09-22 22:56:45 PDT
Comment on attachment 165278 [details] patch Attachment 165278 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13985280
Early Warning System Bot
Comment 4 2012-09-22 22:58:25 PDT
Comment on attachment 165278 [details] patch Attachment 165278 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13993198
Build Bot
Comment 5 2012-09-22 23:05:29 PDT
Comment on attachment 165278 [details] patch Attachment 165278 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13990197
WebKit Review Bot
Comment 6 2012-09-22 23:07:00 PDT
Comment on attachment 165278 [details] patch Attachment 165278 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13986250
Build Bot
Comment 7 2012-09-22 23:18:48 PDT
Comment on attachment 165278 [details] patch Attachment 165278 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13993200
Peter Beverloo (cr-android ews)
Comment 8 2012-09-22 23:31:42 PDT
Comment on attachment 165278 [details] patch Attachment 165278 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13993202
Gyuyoung Kim
Comment 9 2012-09-22 23:44:05 PDT
Comment on attachment 165278 [details] patch Attachment 165278 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13981669
Early Warning System Bot
Comment 10 2012-09-23 00:06:49 PDT
Comment on attachment 165278 [details] patch Attachment 165278 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13986268
Andreas Kling
Comment 11 2012-09-23 07:58:51 PDT
Comment on attachment 165278 [details] patch This is a fantastic cleanup. Obviously needs some build system love. Mac EWS failure: Undefined symbols for architecture x86_64: "__ZN7WebCore8Document18clearStyleResolverEv", referenced from: __ZN7WebCore28DocumentStyleSheetCollection23updateActiveStyleSheetsENS0_10UpdateFlagE in DocumentStyleSheetCollection.o Need to remove inline keyword from Document::clearStyleResolver() implementation I suppose.
Eric Seidel (no email)
Comment 12 2012-09-23 08:51:02 PDT
Huge fan!
Dimitri Glazkov (Google)
Comment 13 2012-09-23 08:55:23 PDT
Kisses!
Eric Seidel (no email)
Comment 14 2012-09-23 21:09:14 PDT
Comment on attachment 165278 [details] patch r- for making the bots mad. I'm excited to see v2!
Antti Koivisto
Comment 15 2012-09-24 11:46:13 PDT
Created attachment 165418 [details] try to make it build - build files for non-mac platforms - svn cp'd Document.cpp so we preserve the history for the moved functions
Antti Koivisto
Comment 16 2012-09-24 12:03:33 PDT
Created attachment 165423 [details] update to tot
Antti Koivisto
Comment 17 2012-09-24 12:16:22 PDT
Created attachment 165426 [details] another try
Antti Koivisto
Comment 18 2012-09-24 13:57:12 PDT
Created attachment 165442 [details] another rebase
Antti Koivisto
Comment 19 2012-09-24 15:14:45 PDT
http://trac.webkit.org/changeset/129423
Note You need to log in before you can comment on or make changes to this bug.