Bug 97342

Summary: [BlackBerry] Media player won't resize for the following source when first source fail to load
Product: WebKit Reporter: Jonathan Dong <jonathan.dong.webkit>
Component: WebKit BlackBerryAssignee: Jonathan Dong <jonathan.dong.webkit>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, eric.carlson, feature-media-reviews, mfeil, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Jonathan Dong 2012-09-21 08:48:46 PDT
RIM PR: 211662

simplified test case:
<html>
    <body>
        <video control>
            <source src="video-do-not-exist.mp4" />
            <source src="video-valid.mp4" />
        </video>
    </body>
</html>

the first source is an invalid url and the second is valid. This issue can also reproduce by test case media/video-size.html

The root cause is if we failed to load the first source, we will accidentally set the video renderer's width and height attributes, which will prevent the second source's intrinsic size if it gets loaded successfully.
Comment 1 Jonathan Dong 2012-09-21 08:52:32 PDT
Created attachment 165139 [details]
Patch
Comment 2 Jonathan Dong 2012-09-21 08:55:23 PDT
Created attachment 165141 [details]
Patch
Comment 3 WebKit Review Bot 2012-09-21 09:31:42 PDT
Comment on attachment 165141 [details]
Patch

Clearing flags on attachment: 165141

Committed r129235: <http://trac.webkit.org/changeset/129235>
Comment 4 WebKit Review Bot 2012-09-21 09:31:45 PDT
All reviewed patches have been landed.  Closing bug.