Summary: | [GTK] Add WebKitWebView:is-loading property to WebKit2 GTK+ API | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gustavo, gyuyoung.kim, mrobinson, rakuco, webkit.review.bot, xan.lopez | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2012-09-21 05:41:35 PDT
Created attachment 165122 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 165122 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165122&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1141 > + webkitWebViewUpdateURI(webView); Maybe it's worth mentioning in the doc that when notify::is-loading is fired you can already get the URI that will be loaded through the get_uri API, even if notify::uri has not happened (seems to me that will be a common thing to do). Committed r129223: <http://trac.webkit.org/changeset/129223> |