Bug 97330 - [GTK] Add WebKitWebView:is-loading property to WebKit2 GTK+ API
Summary: [GTK] Add WebKitWebView:is-loading property to WebKit2 GTK+ API
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2012-09-21 05:41 PDT by Carlos Garcia Campos
Modified: 2012-09-21 06:51 PDT (History)
6 users (show)

See Also:

Patch (19.05 KB, patch)
2012-09-21 05:48 PDT, Carlos Garcia Campos
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-09-21 05:41:35 PDT
To monitor when the view is loading something without having to deal with load-changed signal and all the details about the load status. This also allows to know when a new load is started before it goes to STARTED status.
Comment 1 Carlos Garcia Campos 2012-09-21 05:48:58 PDT
Created attachment 165122 [details]
Comment 2 WebKit Review Bot 2012-09-21 05:53:14 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Xan Lopez 2012-09-21 06:12:17 PDT
Comment on attachment 165122 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=165122&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1141
> +        webkitWebViewUpdateURI(webView);

Maybe it's worth mentioning in the doc that when notify::is-loading is fired you can already get the URI that will be loaded through the get_uri API, even if notify::uri has not happened (seems to me that will be a common thing to do).
Comment 4 Carlos Garcia Campos 2012-09-21 06:51:20 PDT
Committed r129223: <http://trac.webkit.org/changeset/129223>