WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
97330
[GTK] Add WebKitWebView:is-loading property to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=97330
Summary
[GTK] Add WebKitWebView:is-loading property to WebKit2 GTK+ API
Carlos Garcia Campos
Reported
2012-09-21 05:41:35 PDT
To monitor when the view is loading something without having to deal with load-changed signal and all the details about the load status. This also allows to know when a new load is started before it goes to STARTED status.
Attachments
Patch
(19.05 KB, patch)
2012-09-21 05:48 PDT
,
Carlos Garcia Campos
xan.lopez
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2012-09-21 05:48:58 PDT
Created
attachment 165122
[details]
Patch
WebKit Review Bot
Comment 2
2012-09-21 05:53:14 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See
http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Xan Lopez
Comment 3
2012-09-21 06:12:17 PDT
Comment on
attachment 165122
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=165122&action=review
> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1141 > + webkitWebViewUpdateURI(webView);
Maybe it's worth mentioning in the doc that when notify::is-loading is fired you can already get the URI that will be loaded through the get_uri API, even if notify::uri has not happened (seems to me that will be a common thing to do).
Carlos Garcia Campos
Comment 4
2012-09-21 06:51:20 PDT
Committed
r129223
: <
http://trac.webkit.org/changeset/129223
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug