Bug 97321

Summary:

Web Inspector: Highlight multiple nodes in page

Product:

WebKit

Reporter:

Andrei Poenaru <andreigpoenaru>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

apavlov, bburg, bweinstein, gtk-ews, gustavo, joepeck, keishi, loislo, pfeldman, pmuellr, rik, xan.lopez, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
A hack to get multiple highlighting	none
Patch	buildbot: commit-queue-

Andrei Poenaru

Reported 2012-09-21 03:42:09 PDT

Modify the way elements are highlighted in the page in order to add a command to the protocol that takes a list of NodeIds and highlights them.

Attachments
A hack to get multiple highlighting (22.82 KB, patch) 2012-09-21 05:52 PDT, Andrei Poenaru	no flags	Details Formatted Diff Diff
Patch (25.38 KB, patch) 2012-09-24 02:44 PDT, Andrei Poenaru	buildbot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Andrei Poenaru

Comment 1 2012-09-21 05:52:36 PDT

Created attachment 165124 [details] A hack to get multiple highlighting

Pavel Feldman

Comment 2 2012-09-21 06:20:49 PDT

Comment on attachment 165124 [details] A hack to get multiple highlighting View in context: https://bugs.webkit.org/attachment.cgi?id=165124&action=review > Source/WebCore/inspector/Inspector.json:1814 > + { "name": "highlightConfig", "$ref": "HighlightConfig", "description": "A descriptor for the highlight apperance." } I wonder if we want to have a config per node. I can imagine a list of nodes where there is a parent node that is only rendered as border and a list of child nodes that are rendered as boxes. > Source/WebCore/inspector/InspectorController.cpp:82 > + , m_overlays(InspectorOverlayCollection::create(page, inspectorClient)) You should only have one overlay, just make InspectorOverlay::highlightNode receive an array of nodes (and configs).

Andrei Poenaru

Comment 3 2012-09-24 02:44:13 PDT

Created attachment 165338 [details] Patch

Build Bot

Comment 4 2012-09-24 02:48:04 PDT

Comment on attachment 165338 [details] Patch Attachment 165338 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14002333

Gyuyoung Kim

Comment 5 2012-09-24 02:52:15 PDT

Comment on attachment 165338 [details] Patch Attachment 165338 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13997521

Build Bot

Comment 6 2012-09-24 03:12:20 PDT

Comment on attachment 165338 [details] Patch Attachment 165338 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13984713