Summary: | [BlackBerry] Remove obsolete compositing surface code | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Arvid Nilsson <anilsson> | ||||
Component: | WebKit BlackBerry | Assignee: | Arvid Nilsson <anilsson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | anilsson, gyuyoung.kim, jpetsovits, mifenton, rakuco, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Arvid Nilsson
2012-09-21 02:45:56 PDT
PR 208038 Created attachment 165099 [details]
Patch
Comment on attachment 165099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165099&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:-3669 > - if (m_pendingOrientation != -1) > - SurfacePool::globalSurfacePool()->notifyScreenRotated(); > - related? (In reply to comment #3) > (From update of attachment 165099 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165099&action=review > > > Source/WebKit/blackberry/Api/WebPage.cpp:-3669 > > - if (m_pendingOrientation != -1) > > - SurfacePool::globalSurfacePool()->notifyScreenRotated(); > > - > > related? Yes, the only reason the surface pool needed to know about screen rotation, was to reallocate the compositing surface at the new size. So it's not needed any more. Comment on attachment 165099 [details] Patch Clearing flags on attachment: 165099 Committed r129222: <http://trac.webkit.org/changeset/129222> All reviewed patches have been landed. Closing bug. |