Bug 97308

Summary: Build is broken with GLib Unicode backend
Product: WebKit Reporter: Thierry Reding <thierry.reding>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Thierry Reding
Reported 2012-09-21 01:25:19 PDT
The TextBreakIteratorGtk implementation uses ubrk_close() to delete the iterator. However that function is ICU specific and not declared when using the GLib backend. A patch for this has been proposed here: http://permalink.gmane.org/gmane.os.opendarwin.webkit.gtk/1210 I'll follow up with a patch with the proper ChangeLog updates.
Attachments
Patch (2.02 KB, patch)
2012-09-21 01:35 PDT, Thierry Reding 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thierry Reding
Comment 1 2012-09-21 01:35:32 PDT
Created attachment 165078 [details] Patch
Carlos Garcia Campos
Comment 2 2012-09-21 10:03:24 PDT
Comment on attachment 165078 [details] Patch Thanks!
Thierry Reding
Comment 3 2012-09-22 04:13:43 PDT
(In reply to comment #2) > (From update of attachment 165078 [details]) > Thanks! Great. I'm unfamiliar with the procedure and what to do next. Do I repost the patch marking it reviewed by you? Or will somebody with commit access take care of it?
WebKit Review Bot
Comment 4 2012-09-22 04:32:09 PDT
Comment on attachment 165078 [details] Patch Clearing flags on attachment: 165078 Committed r129305: <http://trac.webkit.org/changeset/129305>
WebKit Review Bot
Comment 5 2012-09-22 04:32:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.