Summary: | check-webkit-style is checking all the files, not just my changes | ||
---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED INVALID | ||
Severity: | Normal | CC: | abarth, ap, dpranke, levin |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Tim Horton
2012-09-20 22:58:29 PDT
What is the branch structure of your repository? If you've done a non-fast-forward merge of origin/master, then we might not be computing the diff you expect. (In reply to comment #1) > What is the branch structure of your repository? If you've done a non-fast-forward merge of origin/master, then we might not be computing the diff you expect. That seems a bit odd, I'd expect check-webkit-style to check the same set of files prepare-ChangeLog will write a changelog about... That's more or less what it used to do, but there was a discussion on webkit-dev a while back where folks asked for different semantics. Okiedokie. hm. don't remember that discussion. I certainly wouldn't expect it to be trying to check baselines or expectations files if they weren't changed ... It's not checking the diff since HEAD it's checking the diff against origin/master (or whatever I really mean in git-speak). (In reply to comment #6) > It's not checking the diff since HEAD it's checking the diff against origin/master (or whatever I really mean in git-speak). Oh. That seems more reasonable :). |