Bug 97293

Summary: [EFL] Several MathML tests need rebaseline after r129146
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: dbarton, gyuyoung.kim, kenneth, lucas.de.marchi, naginenis, rakuco, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97228    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2012-09-20 22:40:08 PDT 
We need to rebaseline several MathML tests due to r129146.
Comment 1 Chris Dumez 2012-09-20 22:53:12 PDT 
Created attachment 165054 [details]
Patch

Could someone please cq+ ?
Comment 2 WebKit Review Bot 2012-09-20 23:14:18 PDT 
Comment on attachment 165054 [details]
Patch

Clearing flags on attachment: 165054

Committed r129193: <http://trac.webkit.org/changeset/129193>
Comment 3 WebKit Review Bot 2012-09-20 23:14:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Dave Barton 2012-09-20 23:29:00 PDT 
I just looked at the 17 efl .txt diffs and the 20 gtk .txt diffs on the bots, and they all look similar to the mac ones for bug 97228. I think you can just rebaseline. Update: I now see your patch, the 17 .png file changes look fine to me too.

I am sorry to keep doing this to you. However, I'm just a volunteer and I inherited these MathML tests. I converted a few others to reference tests, but it's harder to change these. I'm not sure what WebKit's preferred method for handling this is.

I do notice that the old platform/efl/mathml/presentation/*.txt and platform/gtk/mathml/presentation/*.txt expected results are identical I believe (except that efl turns 3 tests off). Can we use the layout test expected results search path to somehow have a single directory of linux expected results, that will be used for both efl and gtk? Perhaps it could be used for the Chromium linux port as well?