Bug 97278

Summary:

[WK2] Add basic testing support for Geolocation

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

Tools / Tests

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, maheshk, mario, rakuco, sam, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kenneth: review+

Description Benjamin Poulain 2012-09-20 18:18:05 PDT

The current implementation is a sad hack.

Comment 1 Benjamin Poulain 2012-09-20 18:34:01 PDT

Created attachment 165031 [details]
Patch

Comment 2 Kenneth Rohde Christiansen 2012-09-20 23:04:37 PDT

Comment on attachment 165031 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165031&action=review

LGTM

> Tools/ChangeLog:10
> +
> +

nit: double newline

> Tools/WebKitTestRunner/TestController.cpp:393
> +        decidePolicyForGeolocationPermissionRequest, // decidePolicyForGeolocationPermissionRequest

I dont think that commetn adds any value anymore

Comment 3 Benjamin Poulain 2012-09-21 14:12:25 PDT

Committed r129252: <http://trac.webkit.org/changeset/129252>

Comment 4 Mario Sanchez Prada 2013-10-01 09:01:48 PDT

*** Bug 59201 has been marked as a duplicate of this bug. ***