Summary: | [WK2] Add basic testing support for Geolocation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
Component: | Tools / Tests | Assignee: | Benjamin Poulain <benjamin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gyuyoung.kim, maheshk, mario, rakuco, sam, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Benjamin Poulain
2012-09-20 18:18:05 PDT
Created attachment 165031 [details]
Patch
Comment on attachment 165031 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165031&action=review LGTM > Tools/ChangeLog:10 > + > + nit: double newline > Tools/WebKitTestRunner/TestController.cpp:393 > + decidePolicyForGeolocationPermissionRequest, // decidePolicyForGeolocationPermissionRequest I dont think that commetn adds any value anymore Committed r129252: <http://trac.webkit.org/changeset/129252> |