WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 97278
[WK2] Add basic testing support for Geolocation
https://bugs.webkit.org/show_bug.cgi?id=97278
Summary
[WK2] Add basic testing support for Geolocation
Benjamin Poulain
Reported
2012-09-20 18:18:05 PDT
The current implementation is a sad hack.
Attachments
Patch
(37.08 KB, patch)
2012-09-20 18:34 PDT
,
Benjamin Poulain
kenneth
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2012-09-20 18:34:01 PDT
Created
attachment 165031
[details]
Patch
Kenneth Rohde Christiansen
Comment 2
2012-09-20 23:04:37 PDT
Comment on
attachment 165031
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=165031&action=review
LGTM
> Tools/ChangeLog:10 > + > +
nit: double newline
> Tools/WebKitTestRunner/TestController.cpp:393 > + decidePolicyForGeolocationPermissionRequest, // decidePolicyForGeolocationPermissionRequest
I dont think that commetn adds any value anymore
Benjamin Poulain
Comment 3
2012-09-21 14:12:25 PDT
Committed
r129252
: <
http://trac.webkit.org/changeset/129252
>
Mario Sanchez Prada
Comment 4
2013-10-01 09:01:48 PDT
***
Bug 59201
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug