Bug 97278 - [WK2] Add basic testing support for Geolocation
Summary: [WK2] Add basic testing support for Geolocation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
: 59201 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-09-20 18:18 PDT by Benjamin Poulain
Modified: 2013-10-01 09:01 PDT (History)
6 users (show)

See Also:


Attachments
Patch (37.08 KB, patch)
2012-09-20 18:34 PDT, Benjamin Poulain
kenneth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-09-20 18:18:05 PDT
The current implementation is a sad hack.
Comment 1 Benjamin Poulain 2012-09-20 18:34:01 PDT
Created attachment 165031 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-09-20 23:04:37 PDT
Comment on attachment 165031 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165031&action=review

LGTM

> Tools/ChangeLog:10
> +
> +

nit: double newline

> Tools/WebKitTestRunner/TestController.cpp:393
> +        decidePolicyForGeolocationPermissionRequest, // decidePolicyForGeolocationPermissionRequest

I dont think that commetn adds any value anymore
Comment 3 Benjamin Poulain 2012-09-21 14:12:25 PDT
Committed r129252: <http://trac.webkit.org/changeset/129252>
Comment 4 Mario Sanchez Prada 2013-10-01 09:01:48 PDT
*** Bug 59201 has been marked as a duplicate of this bug. ***