Bug 97272

Summary: Web Inspector: UISourceCode commitWorkingCopy should not fail when original script had syntax error.
Product: WebKit Reporter: johnjbarton <johnjbarton>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, vsevik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

johnjbarton
Reported 2012-09-20 16:37:07 PDT
See http://code.google.com/p/chromium/issues/detail?id=151399 Note that the relevant LayoutTests file is live-edit.html but it is allowed to fail by a line in platform/chromium/TestExpectations See Bug 91435
Attachments
Patch (5.55 KB, patch)
2012-09-20 16:49 PDT, johnjbarton 		no flags
DetailsFormatted DiffDiff
Patch (7.55 KB, patch)
2012-10-03 03:02 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
johnjbarton
Comment 1 2012-09-20 16:49:33 PDT
Created attachment 165013 [details] Patch
Vsevolod Vlasov
Comment 2 2012-09-24 05:12:28 PDT
Comment on attachment 165013 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165013&action=review > Source/WebCore/inspector/front-end/JavaScriptSource.js:104 > + var rawLocation = this.uiLocationToRawLocation(0, 0); We try to avoid exceptions in inspector code. Why not use if (!rawLocation) return; instead? > LayoutTests/inspector/debugger/live-edit.html:14 > + WebInspector.showPanel("scripts"); var panel = WebInspector.showPanel("scripts");
Vsevolod Vlasov
Comment 3 2012-10-03 03:02:37 PDT
Created attachment 166842 [details] Patch
WebKit Review Bot
Comment 4 2012-10-03 07:37:27 PDT
Comment on attachment 166842 [details] Patch Clearing flags on attachment: 166842 Committed r130287: <http://trac.webkit.org/changeset/130287>
WebKit Review Bot
Comment 5 2012-10-03 07:37:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.