Bug 97272

Summary: Web Inspector: UISourceCode commitWorkingCopy should not fail when original script had syntax error.
Product: WebKit Reporter: johnjbarton <johnjbarton>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, vsevik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description johnjbarton 2012-09-20 16:37:07 PDT 
See 
http://code.google.com/p/chromium/issues/detail?id=151399

Note that the relevant LayoutTests file is live-edit.html but it is allowed to fail by a line in 
platform/chromium/TestExpectations
See Bug 91435
Comment 1 johnjbarton 2012-09-20 16:49:33 PDT 
Created attachment 165013 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-09-24 05:12:28 PDT 
Comment on attachment 165013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165013&action=review

> Source/WebCore/inspector/front-end/JavaScriptSource.js:104
> +            var rawLocation = this.uiLocationToRawLocation(0, 0);

We try to avoid exceptions in inspector code.
Why not use 
if (!rawLocation)
    return;
instead?

> LayoutTests/inspector/debugger/live-edit.html:14
> +    WebInspector.showPanel("scripts");

var panel = WebInspector.showPanel("scripts");
Comment 3 Vsevolod Vlasov 2012-10-03 03:02:37 PDT 
Created attachment 166842 [details]
Patch
Comment 4 WebKit Review Bot 2012-10-03 07:37:27 PDT 
Comment on attachment 166842 [details]
Patch

Clearing flags on attachment: 166842

Committed r130287: <http://trac.webkit.org/changeset/130287>
Comment 5 WebKit Review Bot 2012-10-03 07:37:30 PDT 
All reviewed patches have been landed.  Closing bug.