Bug 97195

Summary: [Qt] r129045 broke the ARM build
Product: WebKit Reporter: Gabor Rapcsanyi <rgabor>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, ossy, webkit.review.bot, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Speculative fix
none
Speculative fix 2 none

Description Gabor Rapcsanyi 2012-09-20 04:30:37 PDT 
MacroAssemblerARM.h is missing some store8() implementations.
Comment 1 Gabor Rapcsanyi 2012-09-20 04:46:22 PDT 
Created attachment 164891 [details]
Speculative fix
Comment 2 Zoltan Herczeg 2012-09-20 04:57:26 PDT 
I suggest to use:
move(TrustedImm32(reinterpret_cast<ARMWord>(address)), ARMRegisters::S0);

The immediate does not need to unique. I saw there are other places where these unique constats are used, we should remove them later.
Comment 3 Gabor Rapcsanyi 2012-09-20 05:51:31 PDT 
Created attachment 164900 [details]
Speculative fix 2

I made the change what Zoltan mentioned and deleted the unnecessary store8(RegisterID src, void* address) implementation.
Comment 4 Zoltan Herczeg 2012-09-20 06:04:26 PDT 
Comment on attachment 164900 [details]
Speculative fix 2

r=me
Comment 5 WebKit Review Bot 2012-09-20 06:24:51 PDT 
Comment on attachment 164900 [details]
Speculative fix 2

Clearing flags on attachment: 164900

Committed r129127: <http://trac.webkit.org/changeset/129127>
Comment 6 WebKit Review Bot 2012-09-20 06:24:54 PDT 
All reviewed patches have been landed.  Closing bug.