Bug 97195

Summary: [Qt] r129045 broke the ARM build
Product: WebKit Reporter: Gabor Rapcsanyi <rgabor>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, ossy, webkit.review.bot, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Speculative fix
none
Speculative fix 2 none

Gabor Rapcsanyi
Reported 2012-09-20 04:30:37 PDT
MacroAssemblerARM.h is missing some store8() implementations.
Attachments
Speculative fix (1.89 KB, patch)
2012-09-20 04:46 PDT, Gabor Rapcsanyi 		no flags
DetailsFormatted DiffDiff
Speculative fix 2 (1.64 KB, patch)
2012-09-20 05:51 PDT, Gabor Rapcsanyi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gabor Rapcsanyi
Comment 1 2012-09-20 04:46:22 PDT
Created attachment 164891 [details] Speculative fix
Zoltan Herczeg
Comment 2 2012-09-20 04:57:26 PDT
I suggest to use: move(TrustedImm32(reinterpret_cast<ARMWord>(address)), ARMRegisters::S0); The immediate does not need to unique. I saw there are other places where these unique constats are used, we should remove them later.
Gabor Rapcsanyi
Comment 3 2012-09-20 05:51:31 PDT
Created attachment 164900 [details] Speculative fix 2 I made the change what Zoltan mentioned and deleted the unnecessary store8(RegisterID src, void* address) implementation.
Zoltan Herczeg
Comment 4 2012-09-20 06:04:26 PDT
Comment on attachment 164900 [details] Speculative fix 2 r=me
WebKit Review Bot
Comment 5 2012-09-20 06:24:51 PDT
Comment on attachment 164900 [details] Speculative fix 2 Clearing flags on attachment: 164900 Committed r129127: <http://trac.webkit.org/changeset/129127>
WebKit Review Bot
Comment 6 2012-09-20 06:24:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.