Bug 97193

Summary: Prepare CalendarPicker so we can add another picker, SuggetionPicker
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 96085    
Attachments:
Description Flags
Patch
none
Patch none

Keishi Hattori
Reported 2012-09-20 04:26:35 PDT
Prepare CalendarPicker so we can add another picker, SuggetionPicker
Attachments
Patch (7.62 KB, patch)
2012-09-20 04:48 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (6.87 KB, patch)
2012-09-20 22:27 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-09-20 04:48:39 PDT
Created attachment 164892 [details] Patch
Kent Tamura
Comment 2 2012-09-20 06:12:00 PDT
Comment on attachment 164892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164892&action=review > Source/WebCore/Resources/pagepopups/calendarPicker.js:382 > - var elementHeight = this._element.offsetHeight; > this._element.style.width = "auto"; > daysAreaElement.style.width = "100%"; > daysAreaElement.style.tableLayout = "fixed"; > this._element.getElementsByClassName(ClassNames.YearMonthUpper)[0].style.display = "-webkit-box"; > this._element.getElementsByClassName(ClassNames.MonthSelectorBox)[0].style.display = "block"; > + var elementHeight = this._element.offsetHeight; Why do you move elementHeight? ChangeLog should explain such reasons of changes.
Keishi Hattori
Comment 3 2012-09-20 22:27:30 PDT
Created attachment 165047 [details] Patch
Keishi Hattori
Comment 4 2012-09-20 22:27:42 PDT
(In reply to comment #2) > (From update of attachment 164892 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164892&action=review > > > Source/WebCore/Resources/pagepopups/calendarPicker.js:382 > > - var elementHeight = this._element.offsetHeight; > > this._element.style.width = "auto"; > > daysAreaElement.style.width = "100%"; > > daysAreaElement.style.tableLayout = "fixed"; > > this._element.getElementsByClassName(ClassNames.YearMonthUpper)[0].style.display = "-webkit-box"; > > this._element.getElementsByClassName(ClassNames.MonthSelectorBox)[0].style.display = "block"; > > + var elementHeight = this._element.offsetHeight; > > Why do you move elementHeight? > > ChangeLog should explain such reasons of changes. Removed this change.
Kent Tamura
Comment 5 2012-09-20 22:29:29 PDT
Comment on attachment 165047 [details] Patch ok
WebKit Review Bot
Comment 6 2012-09-21 00:01:59 PDT
Comment on attachment 165047 [details] Patch Clearing flags on attachment: 165047 Committed r129198: <http://trac.webkit.org/changeset/129198>
WebKit Review Bot
Comment 7 2012-09-21 00:02:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.