Bug 97187

Summary: [chromium] Adding the 'google_apis' directory to .gitignore.
Product: WebKit Reporter: Mike West <mkwst>
Component: New BugsAssignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: jochen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
No tabs. none

Mike West
Reported 2012-09-20 03:08:09 PDT
[chromium] Adding the 'google_apis' directory to .gitignore.
Attachments
Patch (1.02 KB, patch)
2012-09-20 03:09 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
No tabs. (1.02 KB, patch)
2012-09-20 03:30 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2012-09-20 03:09:14 PDT
Created attachment 164875 [details] Patch
Mike West
Comment 2 2012-09-20 03:10:24 PDT
Hey Jochen! Mind applying a rubber-stamp R+/CQ+ to a trivial patch? :)
WebKit Review Bot
Comment 3 2012-09-20 03:13:46 PDT
Attachment 164875 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/.gitignore', u'Sour..." exit_code: 1 Source/WebKit/chromium/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mike West
Comment 4 2012-09-20 03:30:36 PDT
Created attachment 164881 [details] No tabs.
jochen
Comment 5 2012-09-20 06:08:57 PDT
Comment on attachment 164881 [details] No tabs. Ok
WebKit Review Bot
Comment 6 2012-09-20 06:13:53 PDT
Comment on attachment 164881 [details] No tabs. Clearing flags on attachment: 164881 Committed r129124: <http://trac.webkit.org/changeset/129124>
WebKit Review Bot
Comment 7 2012-09-20 06:13:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.