Bug 97172

Summary: REGRESSION(r129007): It broke the build on the Qt bots (Requested by Ossy on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: RESOLVED INVALID    
Severity: Normal CC: hausmann, loic.yhuel, ossy, vestbo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
ROLLOUT of r129007 none

Description WebKit Review Bot 2012-09-19 22:47:20 PDT 
http://trac.webkit.org/changeset/129007 broke the build:
It broke the build on the Qt bots (Requested by Ossy on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-09-19 22:47:50 PDT 
Created attachment 164844 [details]
ROLLOUT of r129007

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Csaba Osztrogonác 2012-09-19 22:50:03 PDT 
Comment on attachment 164844 [details]
ROLLOUT of r129007

Clearing flags on attachment: 164844

Committed r129092: <http://trac.webkit.org/changeset/129092>
Comment 3 Csaba Osztrogonác 2012-09-19 22:50:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2012-09-19 22:50:35 PDT 
error:
cc1plus: error: to generate dependencies you must specify either -M or -MM
Comment 5 Csaba Osztrogonác 2012-09-20 01:21:57 PDT 
Reopen, because the bug isn't fixed.
Comment 6 Loïc Yhuel 2012-09-27 16:17:19 PDT 
This patch deleted empty.cpp, instead of reverting to previous state (empty file), so now the gccdepends config test always fails.
Comment 7 Csaba Osztrogonác 2012-11-30 04:49:00 PST 
(In reply to comment #6)
> This patch deleted empty.cpp, instead of reverting to previous state (empty file), so now the gccdepends config test always fails.

Ooops, I added empty empty.cpp back in r136226.

Simon, Tor Arne: Is the original bug still valid? 
Or can we close this as WONTFIX?
Comment 8 Tor Arne Vestbø 2012-11-30 05:19:44 PST 
Barring the broken rollout, the original bug is now reintroduced. We should perhaps figure out how it broke the build so we can fix the original patch.
Comment 9 Csaba Osztrogonác 2012-11-30 05:23:08 PST 
(In reply to comment #8)
> Barring the broken rollout, the original bug is now reintroduced. We should perhaps figure out how it broke the build so we can fix the original patch.

The question is very good after 2 months .... Who remembers what happened that time. Let me try to find the bot history.
Comment 10 Csaba Osztrogonác 2012-11-30 05:30:10 PST 
I checked 2-3 bots history ... but I can't find any useful information. :-/
I can't remember which bots / EWS were broken that time. Let's try to debug
it on monday.
Comment 11 Csaba Osztrogonác 2012-11-30 05:48:36 PST 
(In reply to comment #8)
> Barring the broken rollout, the original bug is now reintroduced.
It means that the "GNUmake gcc_MD_depends" case was always broken
with all-in-one files. But the accidentally missing empty.cpp simple 
disabled "GNUmake gcc_MD_depends" everywhere. That's why nobody noticed it.