Bug 97166

Summary: REGRESSION(r127727): Can't navigate between months with arrow keys in calendar picker
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Keishi Hattori 2012-09-19 21:53:09 PDT 
Can't navigate between months with arrow keys in calendar picker
Comment 1 Keishi Hattori 2012-09-19 22:46:31 PDT 
Created attachment 164842 [details]
Patch
Comment 2 Kent Tamura 2012-09-19 23:00:11 PDT 
Comment on attachment 164842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164842&action=review

> LayoutTests/fast/forms/date/calendar-picker-key-operations.html:33
> +    shouldBe('selectedDate()', '"1999-12-26"');
> +    eventSender.keyDown('upArrow');
> +    shouldBe('selectedDate()', '"2000-01-02"');

I don't understand this.
1999-12-26 + upArrow isn't 1999-12-19?
Comment 3 Keishi Hattori 2012-09-19 23:06:03 PDT 
Comment on attachment 164842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164842&action=review

>> LayoutTests/fast/forms/date/calendar-picker-key-operations.html:33
>> +    shouldBe('selectedDate()', '"2000-01-02"');
> 
> I don't understand this.
> 1999-12-26 + upArrow isn't 1999-12-19?

This is moving from 1999-12-26  in the top row of the January calendar to 2000-01-02 in the last row of the December calendar.
Comment 4 Kent Tamura 2012-09-19 23:15:23 PDT 
Comment on attachment 164842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164842&action=review

>>> LayoutTests/fast/forms/date/calendar-picker-key-operations.html:33
>>> +    shouldBe('selectedDate()', '"2000-01-02"');
>> 
>> I don't understand this.
>> 1999-12-26 + upArrow isn't 1999-12-19?
> 
> This is moving from 1999-12-26  in the top row of the January calendar to 2000-01-02 in the last row of the December calendar.

Oh, I see.

We had better check YearMonthController.year() and month() values in the test, or add comments in the test.
Comment 5 Keishi Hattori 2012-09-19 23:59:56 PDT 
Created attachment 164849 [details]
Patch
Comment 6 Kent Tamura 2012-09-20 01:01:37 PDT 
Comment on attachment 164849 [details]
Patch

ok
Comment 7 WebKit Review Bot 2012-09-20 01:34:58 PDT 
Comment on attachment 164849 [details]
Patch

Clearing flags on attachment: 164849

Committed r129106: <http://trac.webkit.org/changeset/129106>
Comment 8 WebKit Review Bot 2012-09-20 01:35:01 PDT 
All reviewed patches have been landed.  Closing bug.