Summary: | [BlackBerry] Add function playerId() in class PageClientBlackBerry | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Dong <jonathan.dong.webkit> | ||||||
Component: | WebKit BlackBerry | Assignee: | Jonathan Dong <jonathan.dong.webkit> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | charles.wei, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jonathan Dong
2012-09-19 05:18:45 PDT
Created attachment 164722 [details]
Patch
Comment on attachment 164722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164722&action=review otherwise LGTM > Source/WebKit/blackberry/Api/WebPage_p.h:182 > + virtual int playerId() const; according to WebKit style or existing code, we should name it playerID() rather than playerId. Created attachment 164741 [details]
Patch
Comment on attachment 164741 [details] Patch Clearing flags on attachment: 164741 Committed r129010: <http://trac.webkit.org/changeset/129010> All reviewed patches have been landed. Closing bug. |