Bug 97070

Summary: [BlackBerry] remove static_cast which will cause video crash
Product: WebKit Reporter: Jonathan Dong <jonathan.dong.webkit>
Component: WebKit BlackBerryAssignee: Jonathan Dong <jonathan.dong.webkit>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, mfeil, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Dong
Reported 2012-09-18 22:38:13 PDT
RIM PR: 187543 In some cases (e.g. test case media/video-size.html) we haven't had a chance to call load() to create a real media player before we use it, so the MediaPlayer->m_private is still pointing to a NullMediaPlayerPrivate, but we use static_cast to cast it to a (BlackBerry)MediaPlayerPrivate. This is a layering violation and will cause a runtime crash.
Attachments
Patch (2.58 KB, patch)
2012-09-18 22:56 PDT, Jonathan Dong 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Dong
Comment 1 2012-09-18 22:56:55 PDT
Created attachment 164665 [details] Patch
WebKit Review Bot
Comment 2 2012-09-19 07:11:25 PDT
Comment on attachment 164665 [details] Patch Clearing flags on attachment: 164665 Committed r129001: <http://trac.webkit.org/changeset/129001>
WebKit Review Bot
Comment 3 2012-09-19 07:11:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.