Bug 97070

Summary:

[BlackBerry] remove static_cast which will cause video crash

Product:

WebKit

Reporter:

Jonathan Dong <jonathan.dong.webkit>

Component:

WebKit BlackBerry

Assignee:

Jonathan Dong <jonathan.dong.webkit>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

charles.wei, mfeil, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jonathan Dong 2012-09-18 22:38:13 PDT

RIM PR: 187543

In some cases (e.g. test case media/video-size.html) we haven't had a chance to call load() to create a real media player before we use it, so the MediaPlayer->m_private is still pointing to a NullMediaPlayerPrivate, but we use static_cast to cast it to a (BlackBerry)MediaPlayerPrivate. This is a layering violation and will cause a runtime crash.

Comment 1 Jonathan Dong 2012-09-18 22:56:55 PDT

Created attachment 164665 [details]
Patch

Comment 2 WebKit Review Bot 2012-09-19 07:11:25 PDT

Comment on attachment 164665 [details]
Patch

Clearing flags on attachment: 164665

Committed r129001: <http://trac.webkit.org/changeset/129001>

Comment 3 WebKit Review Bot 2012-09-19 07:11:28 PDT

All reviewed patches have been landed.  Closing bug.