Bug 97068

Summary: [Chromium] Don't treat tab as spaces for word-end in HarfBuzzShaper
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: PlatformAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: tony, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kenichi Ishibashi
Reported 2012-09-18 21:46:21 PDT
On harfbuzz-ng enabled chromium linux, fast/text/wide-zero-width-space.html is failing. We can fix it by not treating tab as spaces, like https://bugs.webkit.org/show_bug.cgi?id=94010.
Attachments
Patch (1.74 KB, patch)
2012-09-18 21:52 PDT, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2012-09-18 21:52:27 PDT
Created attachment 164657 [details] Patch
Kenichi Ishibashi
Comment 2 2012-09-18 22:00:33 PDT
Yuta-san, Could you rubber-stamp?
Yuta Kitamura
Comment 3 2012-09-18 22:08:54 PDT
Comment on attachment 164657 [details] Patch Looks legit.
Kenichi Ishibashi
Comment 4 2012-09-18 22:11:25 PDT
Comment on attachment 164657 [details] Patch Thanks!
WebKit Review Bot
Comment 5 2012-09-18 22:25:53 PDT
Comment on attachment 164657 [details] Patch Clearing flags on attachment: 164657 Committed r128965: <http://trac.webkit.org/changeset/128965>
WebKit Review Bot
Comment 6 2012-09-18 22:25:56 PDT
All reviewed patches have been landed. Closing bug.
Tony Chang
Comment 7 2012-09-19 10:12:33 PDT
Comment on attachment 164657 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164657&action=review > Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:158 > + // Don't normalize tabs as they are not treated as spaces for word-end Nit: Please end comments with a period.
Note You need to log in before you can comment on or make changes to this bug.