Bug 97061

Summary: [EFL][WK2] Add log macros for EINA_LOG_DOM_XXX series
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit EFLAssignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kangil.han, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
patch
none
patch none

Jinwoo Song
Reported 2012-09-18 19:37:23 PDT
EFL Webkit2 is using the EINA_LOG_DOM_XXX series in several places to log a message on the specified domain and format. This patch adds log macros to simplify these logging codes.
Attachments
patch (3.31 KB, patch)
2012-09-18 19:39 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
patch (3.46 KB, patch)
2012-09-18 19:45 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2012-09-18 19:39:53 PDT
Created attachment 164644 [details] patch
Jinwoo Song
Comment 2 2012-09-18 19:45:45 PDT
Created attachment 164646 [details] patch include ewk_private.h in the ewk_main.cpp
Gyuyoung Kim
Comment 3 2012-09-18 19:56:21 PDT
Comment on attachment 164646 [details] patch Looks good to me. Could you notify this macro usage to webkit-efl mailing list after landing this patch ?
Kangil Han
Comment 4 2012-09-18 20:02:23 PDT
Looks neat. Thanks!
Jinwoo Song
Comment 5 2012-09-18 20:23:26 PDT
(In reply to comment #3) > (From update of attachment 164646 [details]) > Looks good to me. Could you notify this macro usage to webkit-efl mailing list after landing this patch ? Sure, I'll do it.
WebKit Review Bot
Comment 6 2012-09-18 20:33:13 PDT
Comment on attachment 164646 [details] patch Clearing flags on attachment: 164646 Committed r128962: <http://trac.webkit.org/changeset/128962>
WebKit Review Bot
Comment 7 2012-09-18 20:33:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.