Bug 97060

Summary:

[V8] Remove WorkerContextExecutionProxy::runScript()

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

97057

Attachments:

Description	Flags
Patch	none

Description Kentaro Hara 2012-09-18 19:28:54 PDT

To kill WorkerContextExecutionProxy, we can remove WorkerContextExecutionProxy::runScript().

Comment 1 Kentaro Hara 2012-09-18 19:40:30 PDT

Created attachment 164645 [details]
Patch

Comment 2 Adam Barth 2012-09-19 11:31:15 PDT

Comment on attachment 164645 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164645&action=review

> Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:-274
> -    if (script.IsEmpty())
> -        return v8::Local<v8::Value>();

This check is missing from ScriptRunner::runCompiledScript.  I guess its not needed?

Comment 3 WebKit Review Bot 2012-09-19 11:51:56 PDT

Comment on attachment 164645 [details]
Patch

Clearing flags on attachment: 164645

Committed r129026: <http://trac.webkit.org/changeset/129026>

Comment 4 WebKit Review Bot 2012-09-19 11:52:00 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Kentaro Hara 2012-09-19 17:08:45 PDT

Comment on attachment 164645 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164645&action=review

>> Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:-274
>> -        return v8::Local<v8::Value>();
> 
> This check is missing from ScriptRunner::runCompiledScript.  I guess its not needed?

It's not needed in ScriptRunner::runCompiledScript, but was needed in WorkerContextExecutionProxy::runScript (because line 267 can generate an empty script).