Bug 97047

Summary: NRWT crashes on too many timeouts
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, simon.fraser, slewis, thorton, tony, webkit.review.bot
Priority: P2 Keywords: NRWT
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2012-09-18 14:47:22 PDT
NRWT crashes with an OSError, [Errno 24] Too many open files, if there were too many timeouts. Full stack trace at https://gist.github.com/3746082 Steps to recreate - Modify MockDRT in mock_drt.py to infinite loop in run. def run(self): while True: i = 1 - Run new-run-webkit-tests --platform=mock-chromium --no-build
Attachments
Patch (3.46 KB, patch)
2012-10-09 17:12 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-09-21 11:33:35 PDT
I tried to reproduce this, and wasn't able to easily do so. Mountain Lion. I was using 'lsof' to list open files, and did not see the list of open files increasing as the tests timed out. 12$ $ python --version Python 2.7.2
Don Olmstead
Comment 2 2012-09-21 12:50:01 PDT
The OSError was encountered on Linux. Ubuntu 11.04 using Python 2.7.1+ Going to give it a go on Windows 7 x64 using Python 2.7.2.
Don Olmstead
Comment 3 2012-09-21 17:21:39 PDT
Didn't see the OSError under Windows, but the processes we're still present in Task Manager.
Dirk Pranke
Comment 4 2012-10-09 17:12:49 PDT
Created attachment 167878 [details] Patch
Dirk Pranke
Comment 5 2012-10-09 17:20:35 PDT
This did reproduce on Chromium LInux for me ...
Ojan Vafai
Comment 6 2012-10-09 19:00:44 PDT
Looks fine to me. Tony, WDYT?
WebKit Review Bot
Comment 7 2012-10-10 10:30:51 PDT
Comment on attachment 167878 [details] Patch Clearing flags on attachment: 167878 Committed r130922: <http://trac.webkit.org/changeset/130922>
WebKit Review Bot
Comment 8 2012-10-10 10:30:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.