Bug 97015 – [EFL][WK2] Implement PageClientImpl::isViewFocused.

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Ryuan Choi]

In WebKit2/Efl, PageClientImpl::isViewFocused always return true.
So contents can not receive window.onblur although webview lost focus.

[Ryuan Choi]

Created attachment 164550 [details]
Patch

[Chris Dumez]

Comment on attachment 164550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164550&action=review

Can you unskip any test with this fix?

> Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:45
> +    void setViewFocused(bool isFocused) { m_isViewFocused = isFocused; }

Why do we need this?

> Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:57
> +    virtual bool isViewFocused() { return m_isViewFocused; }

evas_object_focus_get(m_viewWidget) ?

> Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:122
> +    bool m_isViewFocused;

Why do we need a new member? We can certainly get focused state from m_viewWidget, right?

[Ryuan Choi]

Created attachment 164639 [details]
Patch

[Ryuan Choi]

(In reply to comment #2)
> (From update of attachment 164550 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164550&action=review
> 
> Can you unskip any test with this fix?

My results are same with this.

> 
> > Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:45
> > +    void setViewFocused(bool isFocused) { m_isViewFocused = isFocused; }
> 
> Why do we need this?
> 
> > Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:57
> > +    virtual bool isViewFocused() { return m_isViewFocused; }
> 
> evas_object_focus_get(m_viewWidget) ?
> 
> > Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:122
> > +    bool m_isViewFocused;
> 
> Why do we need a new member? We can certainly get focused state from m_viewWidget, right?

yes, it is enough.
Fixed.

[Gyuyoung Kim]

Comment on attachment 164639 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164639&action=review

> Source/WebKit2/ChangeLog:9
> +        So window.onblur events will not be generated when webview lost focus.

lost -> losts ?

[Gyuyoung Kim]

Comment on attachment 164639 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164639&action=review

>> Source/WebKit2/ChangeLog:9
>> +        So window.onblur events will not be generated when webview lost focus.
> 
> lost -> losts ?

No ?

[WebKit Review Bot]

Comment on attachment 164639 [details]
Patch

Clearing flags on attachment: 164639

Committed r128958: <http://trac.webkit.org/changeset/128958>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.