Bug 97012

Summary:

Web Inspector: [Extensions API] postpone requests to add extensions until extension server is initialized

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Kosyakov <caseq>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, johnjbarton, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	vsevik: review+

Andrey Kosyakov

Reported 2012-09-18 06:25:07 PDT

Currently, requests to add extensions may arrive before we actually request extensions list in ExtensionServer.initExtensions(). One reason for that is chromium (InspectorExtensionsRegistry.getExtensionsAsync() is a no-op, we always send the extension list from the browser), another potential code path is remote front-end extensions using window.addExtension(). This may lead to extensions sending requests before extension subsystem is initialized (i.e. we install event listeners etc). Thanks to johnjbarton@chromium.org for investigating this.

Attachments
Patch (2.89 KB, patch) 2012-09-18 06:28 PDT, Andrey Kosyakov	vsevik: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrey Kosyakov

Comment 1 2012-09-18 06:28:36 PDT

Created attachment 164544 [details] Patch

Andrey Kosyakov

Comment 2 2012-09-18 07:14:01 PDT

Committed r128892: <http://trac.webkit.org/changeset/128892>

Note You need to log in before you can comment on or make changes to this bug.