Bug 97011

Summary: Implement 'mask-type' for <mask>
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, donggwan.kim, eric, fmalita, macpherson, menard, pdr, schenney, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://dvcs.w3.org/hg/FXTF/raw-file/tip/masking/index.html#the-mask-type
Bug Depends on:    
Bug Blocks: 95389    
Attachments:
Description Flags
Patch kling: review+, kling: commit-queue-

Dirk Schulze
Reported 2012-09-18 06:24:56 PDT
Implement 'mask-type' for <mask> from the CSS Masking specification. It allows switching the mask to use alpha masking.
Attachments
Patch (21.56 KB, patch)
2012-09-18 06:51 PDT, Dirk Schulze 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2012-09-18 06:51:24 PDT
Created attachment 164549 [details] Patch
Andreas Kling
Comment 2 2012-09-19 08:12:35 PDT
Comment on attachment 164549 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164549&action=review Looks good! r=me with the below mistake fixed. (Perhaps we could even add a test for it?) > Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp:197 > case CSSPropertyMarker: > + case CSSPropertyMaskType: > + return CSSPrimitiveValue::create(svgStyle->maskType()); Beep beep! Mistake here: We shouldn't return the mask type for CSSPropertyMarker.
Dirk Schulze
Comment 3 2012-09-19 10:50:24 PDT
Committed r129018: <http://trac.webkit.org/changeset/129018>
Note You need to log in before you can comment on or make changes to this bug.