Summary: | Implement 'mask-type' for <mask> | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||
Component: | SVG | Assignee: | Dirk Schulze <krit> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cmarcelo, donggwan.kim, eric, fmalita, macpherson, menard, pdr, schenney, webkit.review.bot, zimmermann | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
URL: | http://dvcs.w3.org/hg/FXTF/raw-file/tip/masking/index.html#the-mask-type | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 95389 | ||||||
Attachments: |
|
Description
Dirk Schulze
2012-09-18 06:24:56 PDT
Created attachment 164549 [details]
Patch
Comment on attachment 164549 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164549&action=review Looks good! r=me with the below mistake fixed. (Perhaps we could even add a test for it?) > Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp:197 > case CSSPropertyMarker: > + case CSSPropertyMaskType: > + return CSSPrimitiveValue::create(svgStyle->maskType()); Beep beep! Mistake here: We shouldn't return the mask type for CSSPropertyMarker. Committed r129018: <http://trac.webkit.org/changeset/129018> |