| Summary: | [EFL] Rebaseline several test cases in Skipped list | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | d-r, eric.carlson, feature-media-reviews, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, ryuan.choi, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2012-09-18 04:54:30 PDT
Created attachment 164533 [details]
Patch
Could someone please cq+ ?
Comment on attachment 164533 [details]
Patch
Mistakenly updated a global expectation. Clearing cq until fix.
Created attachment 164535 [details]
Patch
Fix the patch so that it only adds EFL expectations, not global ones. Sorry about that.
Could someone please cq+ ?
Comment on attachment 164535 [details] Patch Clearing flags on attachment: 164535 Committed r128882: <http://trac.webkit.org/changeset/128882> All reviewed patches have been landed. Closing bug. fast/events/dont-loose-last-event.html still fails here and on the bots, so I have skipped it again in <http://trac.webkit.org/changeset/128893>. (In reply to comment #6) > fast/events/dont-loose-last-event.html still fails here and on the bots, so I have skipped it again in <http://trac.webkit.org/changeset/128893>. If you move fast/events/dont-loose-last-event.html back the the Skipped list, the same wrong unskipping is likely to happen again. A bug report should be filed with the diff on the bot and the test should be added to TestExpectations with that bug number. This will make sure the test does not get unskipped by mistake and it will be much easier to fix it later. We don't add tests to the Skipped file anymore, even if it is easier. (In reply to comment #7) > (In reply to comment #6) > > fast/events/dont-loose-last-event.html still fails here and on the bots, so I have skipped it again in <http://trac.webkit.org/changeset/128893>. > > If you move fast/events/dont-loose-last-event.html back the the Skipped list, the same wrong unskipping is likely to happen again. A bug report should be filed with the diff on the bot and the test should be added to TestExpectations with that bug number. This will make sure the test does not get unskipped by mistake and it will be much easier to fix it later. > > We don't add tests to the Skipped file anymore, even if it is easier. https://bugs.webkit.org/show_bug.cgi?id=97021 |