Bug 97000 - [EFL] Rebaseline several test cases in Skipped list
Summary: [EFL] Rebaseline several test cases in Skipped list
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-18 04:54 PDT by Chris Dumez
Modified: 2012-09-18 08:30 PDT (History)
9 users (show)

See Also:


Attachments
Patch (deleted)
2012-09-18 04:57 PDT, Chris Dumez
cdumez: commit-queue-
Details | Formatted Diff | Diff
Patch (deleted)
2012-09-18 05:12 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-09-18 04:54:30 PDT
Several test cases can be unskipped with simple rebaseline.
Comment 1 Chris Dumez 2012-09-18 04:57:07 PDT
Created attachment 164533 [details]
Patch

Could someone please cq+ ?
Comment 2 Chris Dumez 2012-09-18 05:03:55 PDT
Comment on attachment 164533 [details]
Patch

Mistakenly updated a global expectation. Clearing cq until fix.
Comment 3 Chris Dumez 2012-09-18 05:12:15 PDT
Created attachment 164535 [details]
Patch

Fix the patch so that it only adds EFL expectations, not global ones. Sorry about that.

Could someone please cq+ ?
Comment 4 WebKit Review Bot 2012-09-18 06:08:03 PDT
Comment on attachment 164535 [details]
Patch

Clearing flags on attachment: 164535

Committed r128882: <http://trac.webkit.org/changeset/128882>
Comment 5 WebKit Review Bot 2012-09-18 06:08:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-09-18 07:45:36 PDT
fast/events/dont-loose-last-event.html still fails here and on the bots, so I have skipped it again in <http://trac.webkit.org/changeset/128893>.
Comment 7 Chris Dumez 2012-09-18 08:07:20 PDT
(In reply to comment #6)
> fast/events/dont-loose-last-event.html still fails here and on the bots, so I have skipped it again in <http://trac.webkit.org/changeset/128893>.

If you move fast/events/dont-loose-last-event.html back the the Skipped list, the same wrong unskipping is likely to happen again. A bug report should be filed with the diff on the bot and the test should be added to TestExpectations with that bug number. This will make sure the test does not get unskipped by mistake and it will be much easier to fix it later.

We don't add tests to the Skipped file anymore, even if it is easier.
Comment 8 Raphael Kubo da Costa (:rakuco) 2012-09-18 08:30:26 PDT
(In reply to comment #7)
> (In reply to comment #6)
> > fast/events/dont-loose-last-event.html still fails here and on the bots, so I have skipped it again in <http://trac.webkit.org/changeset/128893>.
> 
> If you move fast/events/dont-loose-last-event.html back the the Skipped list, the same wrong unskipping is likely to happen again. A bug report should be filed with the diff on the bot and the test should be added to TestExpectations with that bug number. This will make sure the test does not get unskipped by mistake and it will be much easier to fix it later.
> 
> We don't add tests to the Skipped file anymore, even if it is easier.

https://bugs.webkit.org/show_bug.cgi?id=97021