Bug 96975

Summary: [Gtk] Remove the unused variable warning in GamepadsGtk.cpp using ASSERT_UNUSED macro
Product: WebKit Reporter: Vivek Galatage <vivekgalatage>
Component: WebKitGTKAssignee: Vivek Galatage <vivekgalatage>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch none

Vivek Galatage
Reported 2012-09-17 20:56:01 PDT
The following warning is thrown: ../../Source/WebCore/platform/gtk/GamepadsGtk.cpp: In static member function ‘static gboolean WebCore::GamepadDeviceGtk::readCallback(GObject*, gpointer)’: ../../Source/WebCore/platform/gtk/GamepadsGtk.cpp:85:12: warning: unused variable ‘len’ [-Wunused-variable] This warning can be avoided using the ASSERT_UNUSED macro. Patch to follow.
Attachments
Patch (1.36 KB, patch)
2012-09-17 21:06 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2012-09-17 21:06:36 PDT
Created attachment 164487 [details] Patch
Kentaro Hara
Comment 2 2012-09-17 21:17:56 PDT
Comment on attachment 164487 [details] Patch rs=me
Vivek Galatage
Comment 3 2012-09-17 21:23:39 PDT
(In reply to comment #2) > (From update of attachment 164487 [details]) > rs=me Thank you!
WebKit Review Bot
Comment 4 2012-09-17 21:37:28 PDT
Comment on attachment 164487 [details] Patch Clearing flags on attachment: 164487 Committed r128848: <http://trac.webkit.org/changeset/128848>
WebKit Review Bot
Comment 5 2012-09-17 21:37:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.