Bug 96973

Summary:

DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac

Product:

WebKit

Reporter:

Pratik Solanki <psolanki>

Component:

Tools / Tests

Assignee:

Pratik Solanki <psolanki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, psolanki

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	mitz: review+

Description Pratik Solanki 2012-09-17 20:19:27 PDT

We should pass -Wundef to DRT builds.

Comment 1 Pratik Solanki 2012-09-17 20:25:42 PDT

Created attachment 164486 [details]
Patch

Comment 2 mitz 2012-09-17 20:27:10 PDT

Comment on attachment 164486 [details]
Patch

What about WebKitTestRunner?

Comment 3 Pratik Solanki 2012-09-17 22:12:41 PDT

(In reply to comment #2)
> (From update of attachment 164486 [details])
> What about WebKitTestRunner?

Yeah we should add -Wundef there as well. I'll post an updated patch.

Comment 4 Pratik Solanki 2012-09-17 22:22:39 PDT

Created attachment 164494 [details]
Patch

Comment 5 Pratik Solanki 2012-09-17 23:34:57 PDT

Committed r128852: <http://trac.webkit.org/changeset/128852>