Bug 96973

Summary:

DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac

Product:

WebKit

Reporter:

Pratik Solanki <psolanki>

Component:

Tools / Tests

Assignee:

Pratik Solanki <psolanki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, psolanki

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	mitz: review+

Pratik Solanki

Reported 2012-09-17 20:19:27 PDT

We should pass -Wundef to DRT builds.

Attachments
Patch (1.30 KB, patch) 2012-09-17 20:25 PDT, Pratik Solanki	no flags	Details Formatted Diff Diff
Patch (2.67 KB, patch) 2012-09-17 22:22 PDT, Pratik Solanki	mitz: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pratik Solanki

Comment 1 2012-09-17 20:25:42 PDT

Created attachment 164486 [details] Patch

mitz

Comment 2 2012-09-17 20:27:10 PDT

Comment on attachment 164486 [details] Patch What about WebKitTestRunner?

Pratik Solanki

Comment 3 2012-09-17 22:12:41 PDT

(In reply to comment #2) > (From update of attachment 164486 [details]) > What about WebKitTestRunner? Yeah we should add -Wundef there as well. I'll post an updated patch.

Pratik Solanki

Comment 4 2012-09-17 22:22:39 PDT

Created attachment 164494 [details] Patch

Pratik Solanki

Comment 5 2012-09-17 23:34:57 PDT

Committed r128852: <http://trac.webkit.org/changeset/128852>

Note You need to log in before you can comment on or make changes to this bug.