Summary: | Refactored the arguments object so it doesn't dictate closure layout | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||
Component: | New Bugs | Assignee: | Geoffrey Garen <ggaren> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Geoffrey Garen
2012-09-17 14:46:21 PDT
Created attachment 164459 [details]
Patch
Oliver asked if it's common for websites to capture arguments by name and use the arguments object at the same time. There seems to one idiom where it is common: by-hand implementation of function.bind. I don't believe I've made this case worse than it is today, since this case reifies the arguments object to pass it to slice, etc., which disables our optimizations. Also, I don't believe this patch is incompatible with optimization, if we first eliminated the reification. Committed r128832: <http://trac.webkit.org/changeset/128832> |