Bug 96955

Summary: Refactored the arguments object so it doesn't dictate closure layout
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch oliver: review+

Geoffrey Garen
Reported 2012-09-17 14:46:21 PDT
Refactored the arguments object so it doesn't dictate closure layout
Attachments
Patch (51.91 KB, patch)
2012-09-17 15:09 PDT, Geoffrey Garen 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2012-09-17 15:09:57 PDT
Created attachment 164459 [details] Patch
Geoffrey Garen
Comment 2 2012-09-17 15:12:33 PDT
Oliver asked if it's common for websites to capture arguments by name and use the arguments object at the same time. There seems to one idiom where it is common: by-hand implementation of function.bind. I don't believe I've made this case worse than it is today, since this case reifies the arguments object to pass it to slice, etc., which disables our optimizations. Also, I don't believe this patch is incompatible with optimization, if we first eliminated the reification.
Geoffrey Garen
Comment 3 2012-09-17 18:14:31 PDT
Committed r128832: <http://trac.webkit.org/changeset/128832>
Note You need to log in before you can comment on or make changes to this bug.