Bug 96954

Summary: [BlackBerry] Remove dysfunctional zoom blit in setViewportSize()
Product: WebKit Reporter: Jakob Petsovits <jpetsovits>
Component: WebKit BlackBerryAssignee: Jakob Petsovits <jpetsovits>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jakob Petsovits
Reported 2012-09-17 14:39:58 PDT
The blitContents() call removed by this patch used to be part of scheduleZoomAboutPoint(). Its goal was to display a preview of the zoomed contents, primarily when auto-zoomed after rotation. Nested inside a pair of screen suspend/resume calls, it has been a pointless no-op for a while. Antonio's recent change to remove scheduleZoomAboutPoint() and call zoomAboutPoint() from setViewportSize() directly (the only call site) obsoletes the call completely. The zoomAboutPoint() call itself will cause a re-render and blit right away, so we don't care about any preview. zoomAboutPoint() will also take care of the necessary screen/backingstore suspension. The result is a vastly simplified block of code. Further simplification seems feasible, but is not exactly logically equivalent so I have to check with other people on how exactly they are meant to function. In order to minimize the risk of unintended regressions, this patch leaves out those sensitive pieces.
Attachments
Patch (4.91 KB, patch)
2012-09-17 14:44 PDT, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2012-09-17 14:44:40 PDT
Created attachment 164454 [details] Patch
WebKit Review Bot
Comment 2 2012-09-17 15:50:40 PDT
Comment on attachment 164454 [details] Patch Clearing flags on attachment: 164454 Committed r128817: <http://trac.webkit.org/changeset/128817>
WebKit Review Bot
Comment 3 2012-09-17 15:50:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.