Summary: | REGRESSION (r128678): Several tests fail on WK2 bots (compositing/rtl/rtl-fixed-overflow.html, compositing/rtl/rtl-fixed.html, fast/regions/float-pushed-width-change.html, fast/repaint/fixed-move-after-keyboard-scroll.html) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | Tools / Tests | Assignee: | Beth Dakin <bdakin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, mitz, simon.fraser, slewis, thorton | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2012-09-17 12:44:06 PDT
Confusingly, r128678 added expected results for platform/mac, but those are the same as cross platform ones. Two more tests affected by r128678 on WebKit2 only: fast/repaint/fixed-move-after-keyboard-scroll.html fast/regions/float-pushed-width-change.html Probably because of Beth's fixed position stuff? (In reply to comment #3) > Probably because of Beth's fixed position stuff? Yes, I'm working on it. We need some wk2-specific test results because of the fact that we're only doing setAcceleratedCompositingForFixedPositionEnabled(true) in WK2, not WK1. Created attachment 164453 [details]
Patch
Comment on attachment 164453 [details]
Patch
r=me, assuming you've checked with the person who wrote the test that you're changing (fast/regions/float-pushed-width-change). Does seem safe, though.
Thanks, Tim! http://trac.webkit.org/changeset/128811 |