Bug 96943

Summary: Measure the usage of window.webkitIndexedDB so we can measure the transition to webkit.indexedDB
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: jsbell, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Adam Barth 2012-09-17 12:35:19 PDT
Measure the usage of window.webkitIndexedDB so we can measure the transition to webkit.indexedDB
Comment 1 Adam Barth 2012-09-17 12:36:16 PDT
Created attachment 164441 [details]
Patch
Comment 2 Ojan Vafai 2012-09-17 12:49:32 PDT
Comment on attachment 164441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164441&action=review

> Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.idl:33
> +        readonly attribute [V8MeasureAs=PrefixedIndexedDB] IDBFactory webkitIndexedDB;

bikeshed: Why not WebKitIndexedDB?
Comment 3 Adam Barth 2012-09-17 12:54:01 PDT
(In reply to comment #2)
> (From update of attachment 164441 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164441&action=review
> 
> > Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.idl:33
> > +        readonly attribute [V8MeasureAs=PrefixedIndexedDB] IDBFactory webkitIndexedDB;
> 
> bikeshed: Why not WebKitIndexedDB?

I was planning to call unprefixed one UnprefixedIndexedDB.  Calling the unprefixed one just "IndexedDB" isn't as clear because you don't know if its all uses of IndexedDB.
Comment 4 Adam Barth 2012-09-17 13:37:12 PDT
Comment on attachment 164441 [details]
Patch

Clearing flags on attachment: 164441

Committed r128798: <http://trac.webkit.org/changeset/128798>
Comment 5 Adam Barth 2012-09-17 13:37:13 PDT
All reviewed patches have been landed.  Closing bug.