Summary: | OpenGL building issue when compiling for Harmattan | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Laszlo Papp <lpapp> | ||||||
Component: | Platform | Assignee: | Lauro Moura Maranhao Neto <lauro.neto> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dino, hausmann, lauro.neto, noam, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | Other | ||||||||
Attachments: |
|
Description
Laszlo Papp
2012-09-17 11:56:41 PDT
Created attachment 164474 [details]
Initial fixes
As suggested by Simon over IRC, including qopengles2ext.h from Extensions3DOpenGLES.h helped solve the issue, but just including it causes the build to fail like in https://bugs.webkit.org/show_bug.cgi?id=91030. This is due to qopengles2ext.h defining two of the PFN* extension functions with a PROC suffix (like Khrono's version) while WebKit's own ANGLE copy does not. So, in the first patch are the initial changes to make it past this problem. Wouldn't a qopengl.h include be enough? That would already have the typedef for the GLchar, and would also include the qopengles2ext.h header. Part of the problem is that the qopengles2ext.h header has what I believe is a bug. See also https://codereview.qt-project.org/#change,35004 This can be worked around though by avoiding the inclusion of gl2ext.h. Created attachment 164532 [details]
Patch
Comment on attachment 164532 [details] Patch Clearing flags on attachment: 164532 Committed r128877: <http://trac.webkit.org/changeset/128877> All reviewed patches have been landed. Closing bug. |