Bug 96925

Summary: [BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: WebKit BlackBerryAssignee: Abbas Sherawala <asherawala>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 96696    
Bug Blocks: 96927    
Attachments:
Description Flags
patch
none
patch
rwlbuis: review+
Added missing if none

Antonio Gomes
Reported 2012-09-17 08:20:32 PDT
... by committing the root layer (if needed) right way. Remember, it calls blitVisibleContents, so what we are actually doing is shortcutting when AC content will get on screen.
Attachments
patch (3.49 KB, patch)
2012-09-17 08:25 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
patch (3.30 KB, patch)
2012-09-17 08:41 PDT, Antonio Gomes 		rwlbuis: review+
DetailsFormatted DiffDiff
Added missing if (2.16 KB, patch)
2012-09-19 07:27 PDT, Abbas Sherawala 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2012-09-17 08:25:13 PDT
Created attachment 164399 [details] patch
WebKit Review Bot
Comment 2 2012-09-17 08:26:43 PDT
Attachment 164399 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/BackingStore...." exit_code: 1 Source/WebKit/blackberry/Api/BackingStore.cpp:363: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/Api/BackingStore.cpp:366: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/Api/BackingStore.cpp:370: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antonio Gomes
Comment 3 2012-09-17 08:41:16 PDT
Created attachment 164401 [details] patch Style issues fixed.
Rob Buis
Comment 4 2012-09-17 08:44:32 PDT
Comment on attachment 164401 [details] patch LGTM.
Antonio Gomes
Comment 5 2012-09-17 09:08:54 PDT
http://trac.webkit.org/changeset/128766
Antonio Gomes
Comment 6 2012-09-19 06:53:44 PDT
missing IF
Abbas Sherawala
Comment 7 2012-09-19 07:27:52 PDT
Created attachment 164735 [details] Added missing if Added the missing if
WebKit Review Bot
Comment 8 2012-09-19 07:51:45 PDT
Comment on attachment 164735 [details] Added missing if Clearing flags on attachment: 164735 Committed r129006: <http://trac.webkit.org/changeset/129006>
Note You need to log in before you can comment on or make changes to this bug.