Bug 96913

Summary: Web Inspector: NMI: now when we can detect instrumented classes we can remove addInstrumentedMember and use addMember for everything
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alph, apavlov, benjamin, bweinstein, cmarcelo, eric.carlson, eric, feature-media-reviews, fmalita, haraken, japhet, joepeck, keishi, loislo, macpherson, menard, pdr, pfeldman, pmuellr, rik, schenney, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
comment addressed - visited check returned
none
rebaselined yurys: review+

Description Ilya Tikhonovsky 2012-09-17 06:19:59 PDT
EOM
Comment 1 Ilya Tikhonovsky 2012-09-17 06:24:25 PDT
Created attachment 164381 [details]
Patch
Comment 2 Yury Semikhatsky 2012-09-17 06:37:24 PDT
Comment on attachment 164381 [details]
Patch

Before switching to the new instrumentaion we should make sure it works, in particular the problem with MemoryInstrumentationTest failure should be addressed first: http://trac.webkit.org/changeset/128744
Comment 3 Ilya Tikhonovsky 2012-09-17 06:47:07 PDT
Created attachment 164387 [details]
comment addressed - visited check returned
Comment 4 Ilya Tikhonovsky 2012-09-17 06:58:36 PDT
Created attachment 164388 [details]
rebaselined
Comment 5 Ilya Tikhonovsky 2012-09-17 08:12:15 PDT
Committed r128762: <http://trac.webkit.org/changeset/128762>