Summary: | [EFL] Remove background view on EWebLauncher and MiniBrowser | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Seokju Kwon <seokju.kwon> | ||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Seokju Kwon
2012-09-17 04:17:26 PDT
Created attachment 164367 [details]
Patch
Comment on attachment 164367 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164367&action=review > Tools/ChangeLog:9 > + The background view doesn't display properly on test browsers after adding url bar. > + And Remove unnecessary codes. The changes themselves look OK, but what kind of display failures were you experiencing? Plus, you only seem to be removing code related to the background view, not unnecessary one. (In reply to comment #2) > (From update of attachment 164367 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164367&action=review > > > Tools/ChangeLog:9 > > + The background view doesn't display properly on test browsers after adding url bar. > > + And Remove unnecessary codes. > > The changes themselves look OK, but what kind of display failures were you experiencing? Plus, you only seem to be removing code related to the background view, not unnecessary one. I couldn't see the pink background any more after adding url bar. Plus Could you explain why it is necessary? (In reply to comment #3) > I couldn't see the pink background any more after adding url bar. Makes sense, since r126419 changed the evas_object_{move,resize} calls. I would just say in the ChangeLog that having the background view is not necessary anymore, since it was used for debugging back in the day. > Plus Could you explain why it is necessary? ? (In reply to comment #4) > (In reply to comment #3) > > I couldn't see the pink background any more after adding url bar. > > Makes sense, since r126419 changed the evas_object_{move,resize} calls. I would just say in the ChangeLog that having the background view is not necessary anymore, since it was used for debugging back in the day. > > > Plus Could you explain why it is necessary? > > ? I was just wondering whether background view is necessary or not now. Created attachment 164523 [details]
Patch
Comment on attachment 164523 [details]
Patch
Looks good, thanks.
Comment on attachment 164523 [details] Patch Clearing flags on attachment: 164523 Committed r128876: <http://trac.webkit.org/changeset/128876> All reviewed patches have been landed. Closing bug. |