Bug 96899

Summary: [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebKitGTKAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2012-09-17 00:27:45 PDT
fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html is failing after introduced in r128645. http://trac.webkit.org/changeset/128645 --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-actual.txt @@ -1,3 +1,3 @@ Test that DisplayImages disabled can block http image and can be reloaded in-place when toggled. -SUCCESS +FAILURE: Image should not be loaded when DisplayImage is unset The test overrides WebKitDisplayImagesKey preference, but that's not yet supported.
Attachments
Patch (6.83 KB, patch)
2012-09-17 11:46 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (3.27 KB, patch)
2012-09-17 13:43 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-09-17 11:46:25 PDT
Created attachment 164428 [details] Patch
Martin Robinson
Comment 2 2012-09-17 12:46:10 PDT
Comment on attachment 164428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164428&action=review > Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:707 > +void DumpRenderTreeSupportGtk::setLoadsImagesAutomatically(WebKitWebView* webView, bool enabled) > +{ > + core(webView)->settings()->setLoadsImagesAutomatically(enabled); > +} Why not just use the auto-load-images setting in WebKitWebSettings?
Zan Dobersek
Comment 3 2012-09-17 12:50:02 PDT
Comment on attachment 164428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164428&action=review >> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:707 >> +} > > Why not just use the auto-load-images setting in WebKitWebSettings? Ah, didn't see that when I was grepping. Of course, using that would be better.
Zan Dobersek
Comment 4 2012-09-17 13:43:35 PDT
Created attachment 164449 [details] Patch
Martin Robinson
Comment 5 2012-09-17 13:49:56 PDT
Comment on attachment 164449 [details] Patch Thanks!
Zan Dobersek
Comment 6 2012-09-17 23:56:03 PDT
Comment on attachment 164449 [details] Patch Clearing flags on attachment: 164449 Committed r128854: <http://trac.webkit.org/changeset/128854>
Zan Dobersek
Comment 7 2012-09-17 23:56:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.