Summary: | [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
Component: | WebKitGTK | Assignee: | Zan Dobersek <zan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | mrobinson, pnormand | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Zan Dobersek
2012-09-17 00:27:45 PDT
Created attachment 164428 [details]
Patch
Comment on attachment 164428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164428&action=review > Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:707 > +void DumpRenderTreeSupportGtk::setLoadsImagesAutomatically(WebKitWebView* webView, bool enabled) > +{ > + core(webView)->settings()->setLoadsImagesAutomatically(enabled); > +} Why not just use the auto-load-images setting in WebKitWebSettings? Comment on attachment 164428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164428&action=review >> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:707 >> +} > > Why not just use the auto-load-images setting in WebKitWebSettings? Ah, didn't see that when I was grepping. Of course, using that would be better. Created attachment 164449 [details]
Patch
Comment on attachment 164449 [details]
Patch
Thanks!
Comment on attachment 164449 [details] Patch Clearing flags on attachment: 164449 Committed r128854: <http://trac.webkit.org/changeset/128854> All reviewed patches have been landed. Closing bug. |