Bug 96871

Summary: [chromium] Add trace events to track WebGL and Accelerated Canvas creation
Product: WebKit Reporter: Vangelis Kokkevis <vangelis>
Component: WebCore Misc.Assignee: Vangelis Kokkevis <vangelis>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Vangelis Kokkevis
Reported 2012-09-15 15:35:04 PDT
Add "gpu_test" trace events that we can use to track the creation of WebGL and accelerated canvas in browser_tests. The current test we have in place that looks for SwapBuffers events won't work when we're in force-compositing-mode.
Attachments
Patch (3.16 KB, patch)
2012-09-15 15:51 PDT, Vangelis Kokkevis 		no flags
DetailsFormatted DiffDiff
Patch (3.20 KB, patch)
2012-09-17 10:27 PDT, Vangelis Kokkevis 		no flags
DetailsFormatted DiffDiff
Patch (3.13 KB, patch)
2012-09-17 10:47 PDT, Vangelis Kokkevis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Vangelis Kokkevis
Comment 1 2012-09-15 15:51:41 PDT
Created attachment 164297 [details] Patch
WebKit Review Bot
Comment 2 2012-09-16 19:17:08 PDT
Comment on attachment 164297 [details] Patch Rejecting attachment 164297 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13878170
Vangelis Kokkevis
Comment 3 2012-09-17 10:27:15 PDT
Created attachment 164412 [details] Patch
WebKit Review Bot
Comment 4 2012-09-17 10:38:51 PDT
Comment on attachment 164412 [details] Patch Rejecting attachment 164412 [details] from review queue. vangelis@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
Vangelis Kokkevis
Comment 5 2012-09-17 10:47:21 PDT
Created attachment 164417 [details] Patch
WebKit Review Bot
Comment 6 2012-09-17 11:35:50 PDT
Comment on attachment 164417 [details] Patch Clearing flags on attachment: 164417 Committed r128785: <http://trac.webkit.org/changeset/128785>
WebKit Review Bot
Comment 7 2012-09-17 11:35:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.