Bug 96832

Summary: new fast/loader tests from r128645 fail on Mac-wk2
Product: WebKit Reporter: Stephanie Lewis <slewis>
Component: WebKit2Assignee: Bo Liu <boliu>
Severity: Normal CC: abarth, boliu, slewis, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar, MakingBotsRed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Stephanie Lewis 2012-09-14 15:27:08 PDT
* fast/loader/display-image-unset-can-block-image-and-can-reload-in-place,html
* fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html

Introduce in changeset http://trac.webkit.org/changeset/128645.


I don't believe WKTR has queueReload.

--- /Volumes/Data/slave/lion-release-tests-wk2/build/layout-test-results/fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt
+++ /Volumes/Data/slave/lion-release-tests-wk2/build/layout-test-results/fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-actual.txt
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 13: TypeError: 'undefined' is not a function (evaluating 'testRunner.queueReload()')
 Test that DisplayImages disabled can block http image and can be reloaded in-place when toggled.
+FAILURE: Image should not be loaded when DisplayImage is unset
Comment 1 Radar WebKit Bug Importer 2012-09-14 15:27:17 PDT
Comment 2 Bo Liu 2012-09-14 15:35:04 PDT
Is the correct fix to implement queueReload since it is used in other tests as well? eg: LayoutTests/fast/loader/reload-policy-delegate.html
Comment 3 Stephanie Lewis 2012-09-14 15:42:11 PDT
most likely
Comment 4 Bo Liu 2012-09-14 15:48:44 PDT
Sorry, 128645 was my first webkit patch, so I'm still getting familiar with things and will probably take awhile to implement queueReload correctly.

Can I get a sense of how urgent this is? Is there a way to temporarily mark these tests as expect crash just for mac webkit2? How are the other tests relying on queueReload handled in mac webkit2?
Comment 5 Adam Barth 2012-09-14 15:50:25 PDT
Typically we just skip tests for a given port if they haven't implemented all the necessary TestRuner features.
Comment 6 Stephanie Lewis 2012-09-14 15:51:46 PDT
Updated TestExpectations in http://trac.webkit.org/projects/webkit/changeset/128664.

Not incredibly urgent :).  I believe the other tests are skipped.
Comment 7 Bo Liu 2012-09-14 16:01:17 PDT
Created attachment 164245 [details]
Comment 8 Bo Liu 2012-09-14 17:59:12 PDT
(In reply to comment #7)
> Created an attachment (id=164245) [details]
> Patch

Ping! (Not sure if webkit-patch upload sends out email to reviewers)
Comment 9 Adam Barth 2012-09-14 18:01:37 PDT
> Ping! (Not sure if webkit-patch upload sends out email to reviewers)

It does (or rather bugzilla does).
Comment 10 WebKit Review Bot 2012-09-14 18:21:43 PDT
Comment on attachment 164245 [details]

Clearing flags on attachment: 164245

Committed r128676: <http://trac.webkit.org/changeset/128676>
Comment 11 WebKit Review Bot 2012-09-14 18:21:46 PDT
All reviewed patches have been landed.  Closing bug.