Summary: | new fast/loader tests from r128645 fail on Mac-wk2 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Stephanie Lewis <slewis> | ||||
Component: | WebKit2 | Assignee: | Bo Liu <boliu> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, boliu, slewis, webkit-bug-importer, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar, MakingBotsRed | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Stephanie Lewis
2012-09-14 15:27:08 PDT
Is the correct fix to implement queueReload since it is used in other tests as well? eg: LayoutTests/fast/loader/reload-policy-delegate.html most likely Sorry, 128645 was my first webkit patch, so I'm still getting familiar with things and will probably take awhile to implement queueReload correctly. Can I get a sense of how urgent this is? Is there a way to temporarily mark these tests as expect crash just for mac webkit2? How are the other tests relying on queueReload handled in mac webkit2? Typically we just skip tests for a given port if they haven't implemented all the necessary TestRuner features. Updated TestExpectations in http://trac.webkit.org/projects/webkit/changeset/128664. Not incredibly urgent :). I believe the other tests are skipped. Created attachment 164245 [details]
Patch
(In reply to comment #7) > Created an attachment (id=164245) [details] > Patch Ping! (Not sure if webkit-patch upload sends out email to reviewers) > Ping! (Not sure if webkit-patch upload sends out email to reviewers)
It does (or rather bugzilla does).
Comment on attachment 164245 [details] Patch Clearing flags on attachment: 164245 Committed r128676: <http://trac.webkit.org/changeset/128676> All reviewed patches have been landed. Closing bug. |