Summary: | Fix LoadImagesAutomatically cache behavior | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Bo Liu <boliu> | ||||||||
Component: | New Bugs | Assignee: | Bo Liu <boliu> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, japhet, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Bo Liu
2012-09-14 15:15:59 PDT
Created attachment 164235 [details]
Patch
Comment on attachment 164235 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164235&action=review Can we add a test for this so we don't break it in the future? > Source/WebCore/loader/cache/CachedResourceLoader.cpp:535 > - if (existingResource->type() == CachedResource::ImageResource && shouldDeferImageLoad(existingResource->url())) > + if (existingResource->type() == CachedResource::ImageResource && !clientAllowImage(existingResource->url())) clientAllowImage -> clientAllowsImage ? Created attachment 164264 [details]
Add layout test that fails without this patch. Rename method to clientAllowsImage
Created attachment 164265 [details]
Skip new test in webkit2 since overridePreference is not supported.
Comment on attachment 164265 [details]
Skip new test in webkit2 since overridePreference is not supported.
Thanks.
Comment on attachment 164265 [details] Skip new test in webkit2 since overridePreference is not supported. Clearing flags on attachment: 164265 Committed r128780: <http://trac.webkit.org/changeset/128780> All reviewed patches have been landed. Closing bug. |