Bug 96829

Summary: Fix LoadImagesAutomatically cache behavior
Product: WebKit Reporter: Bo Liu <boliu>
Component: New BugsAssignee: Bo Liu <boliu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Add layout test that fails without this patch. Rename method to clientAllowsImage
none
Skip new test in webkit2 since overridePreference is not supported. none

Description Bo Liu 2012-09-14 15:15:59 PDT
Fix LoadImagesAutomatically cache behavior
Comment 1 Bo Liu 2012-09-14 15:18:53 PDT
Created attachment 164235 [details]
Patch
Comment 2 Adam Barth 2012-09-14 15:23:22 PDT
Comment on attachment 164235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164235&action=review

Can we add a test for this so we don't break it in the future?

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:535
> -    if (existingResource->type() == CachedResource::ImageResource && shouldDeferImageLoad(existingResource->url()))
> +    if (existingResource->type() == CachedResource::ImageResource && !clientAllowImage(existingResource->url()))

clientAllowImage -> clientAllowsImage ?
Comment 3 Bo Liu 2012-09-14 19:19:43 PDT
Created attachment 164264 [details]
Add layout test that fails without this patch. Rename method to clientAllowsImage
Comment 4 Bo Liu 2012-09-14 19:29:53 PDT
Created attachment 164265 [details]
Skip new test in webkit2 since overridePreference is not supported.
Comment 5 Adam Barth 2012-09-17 11:01:50 PDT
Comment on attachment 164265 [details]
Skip new test in webkit2 since overridePreference is not supported.

Thanks.
Comment 6 WebKit Review Bot 2012-09-17 11:19:35 PDT
Comment on attachment 164265 [details]
Skip new test in webkit2 since overridePreference is not supported.

Clearing flags on attachment: 164265

Committed r128780: <http://trac.webkit.org/changeset/128780>
Comment 7 WebKit Review Bot 2012-09-17 11:19:37 PDT
All reviewed patches have been landed.  Closing bug.