Bug 96822

Summary: [Qt] Cleanup/refactor the user agent detection code
Product: WebKit Reporter: Lauro Moura Maranhao Neto <lauro.neto>
Component: WebKit QtAssignee: Lauro Moura Maranhao Neto <lauro.neto>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Lauro Moura Maranhao Neto
Reported 2012-09-14 13:14:12 PDT
Followup bug after suggestions made to the original useragent patch in https://bugs.webkit.org/show_bug.cgi?id=73917
Attachments
Patch (4.63 KB, patch)
2012-09-14 14:56 PDT, Lauro Moura Maranhao Neto 		no flags
DetailsFormatted DiffDiff
Patch (1.76 KB, patch)
2012-09-17 10:31 PDT, Lauro Moura Maranhao Neto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lauro Moura Maranhao Neto
Comment 1 2012-09-14 14:56:11 PDT
Created attachment 164231 [details] Patch Replaced Q_WS/Q_OS checks with WTF OS()/CPU(). Instead of Q_WS_X11, now checking QGuiApplication::platformName().
Simon Hausmann
Comment 2 2012-09-14 15:17:03 PDT
Comment on attachment 164231 [details] Patch r=me. Might want to double check with the EWS before landing.
WebKit Review Bot
Comment 3 2012-09-17 09:35:27 PDT
Comment on attachment 164231 [details] Patch Clearing flags on attachment: 164231 Committed r128770: <http://trac.webkit.org/changeset/128770>
WebKit Review Bot
Comment 4 2012-09-17 09:35:29 PDT
All reviewed patches have been landed. Closing bug.
Lauro Moura Maranhao Neto
Comment 5 2012-09-17 10:19:46 PDT
Reopen as it broke the windows bot.
Lauro Moura Maranhao Neto
Comment 6 2012-09-17 10:31:17 PDT
Created attachment 164413 [details] Patch
WebKit Review Bot
Comment 7 2012-09-17 10:54:33 PDT
Comment on attachment 164413 [details] Patch Clearing flags on attachment: 164413 Committed r128775: <http://trac.webkit.org/changeset/128775>
WebKit Review Bot
Comment 8 2012-09-17 10:54:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.