Bug 96802

Summary: [Chromium] IndexedDB: Remove legacy two-phase open() API members
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, dglazkov, dgrogan, fishd, jamesr, peter+ews, tkent+wkapi, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Joshua Bell
Reported 2012-09-14 10:07:32 PDT
[Chromium] IndexedDB: Remove legacy two-phase open() API members
Attachments
Patch (5.01 KB, patch)
2012-09-14 10:09 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-09-14 10:09:47 PDT
Created attachment 164177 [details] Patch
Joshua Bell
Comment 2 2012-09-14 10:12:04 PDT
https://codereview.chromium.org/10916318 needs to land first.
Joshua Bell
Comment 3 2012-09-14 16:47:48 PDT
Chromium side has landed, this is ready for review. dgrogan@ - can you take a look?
WebKit Review Bot
Comment 4 2012-09-14 16:48:32 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
David Grogan
Comment 5 2012-09-14 16:48:36 PDT
Comment on attachment 164177 [details] Patch LGTM
WebKit Review Bot
Comment 6 2012-09-14 17:07:27 PDT
Comment on attachment 164177 [details] Patch Attachment 164177 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13851698
Peter Beverloo (cr-android ews)
Comment 7 2012-09-14 18:21:33 PDT
Comment on attachment 164177 [details] Patch Attachment 164177 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13852617
Joshua Bell
Comment 8 2012-09-17 09:17:39 PDT
I think chromium DEPS just needed to roll. Retrying the CQ.
WebKit Review Bot
Comment 9 2012-09-17 10:13:22 PDT
Comment on attachment 164177 [details] Patch Clearing flags on attachment: 164177 Committed r128773: <http://trac.webkit.org/changeset/128773>
WebKit Review Bot
Comment 10 2012-09-17 10:13:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.