Bug 96791

Summary: Web Inspector: OwnPtr and RefPtr reported by pointer can be double counted by the memory instrumentation
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: alph, apavlov, benjamin, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch apavlov: review+, apavlov: commit-queue+

Yury Semikhatsky
Reported 2012-09-14 08:26:37 PDT
MemoryInstrumentation::addObjectImpl(const OwnPtr<T>* const... MemoryInstrumentation::addObjectImpl(const RefPtr<T>* const.. Should check if the smart pointer has already been visited before counting its size.
Attachments
Patch (5.80 KB, patch)
2012-09-14 08:29 PDT, Yury Semikhatsky 		apavlov: review+
apavlov: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-09-14 08:29:31 PDT
Created attachment 164160 [details] Patch
Ilya Tikhonovsky
Comment 2 2012-09-14 08:32:37 PDT
Comment on attachment 164160 [details] Patch lgtm
Alexander Pavlov (apavlov)
Comment 3 2012-09-17 00:40:06 PDT
Comment on attachment 164160 [details] Patch rs=me
Yury Semikhatsky
Comment 4 2012-09-17 00:43:13 PDT
Committed r128721: <http://trac.webkit.org/changeset/128721>
Note You need to log in before you can comment on or make changes to this bug.