Bug 96791

Summary: Web Inspector: OwnPtr and RefPtr reported by pointer can be double counted by the memory instrumentation
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: alph, apavlov, benjamin, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch apavlov: review+, apavlov: commit-queue+

Description Yury Semikhatsky 2012-09-14 08:26:37 PDT 
MemoryInstrumentation::addObjectImpl(const OwnPtr<T>* const...
MemoryInstrumentation::addObjectImpl(const RefPtr<T>* const..
Should check if the smart pointer has already been visited before
counting its size.
Comment 1 Yury Semikhatsky 2012-09-14 08:29:31 PDT 
Created attachment 164160 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-09-14 08:32:37 PDT 
Comment on attachment 164160 [details]
Patch

lgtm
Comment 3 Alexander Pavlov (apavlov) 2012-09-17 00:40:06 PDT 
Comment on attachment 164160 [details]
Patch

rs=me
Comment 4 Yury Semikhatsky 2012-09-17 00:43:13 PDT 
Committed r128721: <http://trac.webkit.org/changeset/128721>