Summary: | [V8] Prevent workers from calling back into other worlds | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dan Carney <dcarney> | ||||
Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, haraken, japhet, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dan Carney
2012-09-14 08:25:23 PDT
Created attachment 164161 [details]
Patch
trying to track down cause of this flake: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&tests=close-code-and-reason.html Comment on attachment 164161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164161&action=review > Source/WebCore/bindings/v8/WorldContextHandle.cpp:51 > + if (v8::Context::InContext()) { > + v8::Handle<v8::Context> context = v8::Context::GetCurrent(); > + if (!context.IsEmpty()) { This is somewhat redundant. You can skip the v8::Context::InContext() call and just test whether v8::Context::GetCurrent() returns an empty handle. (In reply to comment #3) > (From update of attachment 164161 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164161&action=review > > > Source/WebCore/bindings/v8/WorldContextHandle.cpp:51 > > + if (v8::Context::InContext()) { > > + v8::Handle<v8::Context> context = v8::Context::GetCurrent(); > > + if (!context.IsEmpty()) { > > This is somewhat redundant. You can skip the v8::Context::InContext() call and just test whether v8::Context::GetCurrent() returns an empty handle. That's what I had at first, but v8 crashes on GetCurrent when not in context. > That's what I had at first, but v8 crashes on GetCurrent when not in context.
Really! I didn't know that.
Comment on attachment 164161 [details] Patch Clearing flags on attachment: 164161 Committed r128651: <http://trac.webkit.org/changeset/128651> All reviewed patches have been landed. Closing bug. |