Summary: | [BlackBerry] Prevent scroll adjustment of input fields when region of interest mechanism active | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Arvid Nilsson <anilsson> | ||||
Component: | WebKit BlackBerry | Assignee: | Arvid Nilsson <anilsson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | anilsson, mifenton, rwlbuis, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Arvid Nilsson
2012-09-14 04:02:28 PDT
Created attachment 164252 [details]
Patch
Comment on attachment 164252 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164252&action=review > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1055 > - if (!Platform::Settings::instance()->allowCenterScrollAdjustmentForInputFields() && scrollType != EdgeIfNeeded) > + if (!(Platform::Settings::instance()->allowedScrollAdjustmentForInputFields() & scrollType)) I would name it scrollAdjustmentForInputFieldsPolicy, but this this also ok. > Source/WebKit/blackberry/WebKitSupport/InputHandler.h:71 > + enum CaretScrollType { CenterAlways = BlackBerry::Platform::Settings::ScrollAdjustmentCenterAlways, > + CenterIfNeeded = BlackBerry::Platform::Settings::ScrollAdjustmentCenterIfNeeded, > + EdgeIfNeeded = BlackBerry::Platform::Settings::ScrollAdjustmentEdgeIfNeeded }; there are compile asserts we can add to ensure these values match. Comment on attachment 164252 [details] Patch Clearing flags on attachment: 164252 Committed r128858: <http://trac.webkit.org/changeset/128858> All reviewed patches have been landed. Closing bug. |