Bug 96745

Summary: Create Localizer factory method for LocaleNone
Product: WebKit Reporter: yosin
Component: PlatformAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, gyuyoung.kim, keishi, philn, rakuco, tkent, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 96351    
Attachments:
Description Flags
Patch 1
none
Patch 2
none
Patch 3
none
Patch 4
none
Patch 5 none

yosin
Reported 2012-09-14 03:15:28 PDT
Create Localizer factory method for LocaleNone.
Attachments
Patch 1 (8.76 KB, patch)
2012-09-14 03:55 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (8.76 KB, patch)
2012-09-14 03:56 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 3 (5.86 KB, patch)
2012-09-14 04:09 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 4 (7.11 KB, patch)
2012-09-14 04:30 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 5 (6.91 KB, patch)
2012-09-14 04:34 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-09-14 03:55:18 PDT
Created attachment 164094 [details] Patch 1
yosin
Comment 2 2012-09-14 03:56:40 PDT
Created attachment 164095 [details] Patch 2
yosin
Comment 3 2012-09-14 03:57:20 PDT
Comment on attachment 164095 [details] Patch 2 Could you review this patch? Thanks in advance.
yosin
Comment 4 2012-09-14 04:09:34 PDT
Created attachment 164098 [details] Patch 3
Kent Tamura
Comment 5 2012-09-14 04:18:00 PDT
Comment on attachment 164098 [details] Patch 3 View in context: https://bugs.webkit.org/attachment.cgi?id=164098&action=review > Source/WebCore/platform/text/LocaleNone.cpp:10 > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above Please use two-clauses version of copyright header.
Kent Tamura
Comment 6 2012-09-14 04:20:54 PDT
Comment on attachment 164098 [details] Patch 3 View in context: https://bugs.webkit.org/attachment.cgi?id=164098&action=review > Source/WebCore/ChangeLog:16 > + * CMakeLists.txt: Added platform/text/LocaleNone.cpp. > + * GNUmakefile.list.am: Added platform/text/LocaleNone.cpp > + * Target.pri: Added platform/text/LocaleNone.cpp. > + * WebCore.vcproj/WebCore.vcproj: Added platform/text/LocaleNone.cpp We need to add Localizer.{cpp.h} too.
yosin
Comment 7 2012-09-14 04:30:47 PDT
Created attachment 164101 [details] Patch 4
yosin
Comment 8 2012-09-14 04:34:07 PDT
Created attachment 164102 [details] Patch 5
yosin
Comment 9 2012-09-14 04:43:14 PDT
Comment on attachment 164102 [details] Patch 5 Could you review this patch? Thanks in advance.
Kent Tamura
Comment 10 2012-09-14 04:44:13 PDT
Comment on attachment 164102 [details] Patch 5 ok Please watch the bots after landing.
Kent Tamura
Comment 11 2012-09-14 04:49:00 PDT
Comment on attachment 164102 [details] Patch 5 Clearing flags on attachment: 164102 Committed r128588: <http://trac.webkit.org/changeset/128588>
Kent Tamura
Comment 12 2012-09-14 04:49:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.