Summary: | [Chromium] Layout Test fast/forms/*-multiple-fields/*-multiple-fields-preserve-value-after-history-back.html is failing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||
Component: | Tools / Tests | Assignee: | yosin | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | haraken, keishi, ksakamoto, morrita, rjkroege, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kent Tamura
2012-09-13 20:15:09 PDT
*** Bug 103152 has been marked as a duplicate of this bug. *** All of fast/forms/*-multiple-fields/*-multiple-fields-preserve-value-after-history-back.html are flaky. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=preserve-value-after-history Created attachment 176922 [details]
Patch
Comment on attachment 176922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176922&action=review > LayoutTests/ChangeLog:3 > + [Chroimum] Layout Test fast/forms/*-multiple-fields/*-multiple-fields-preserve-value-after-history-back.html is failing Typo: Chromium > LayoutTests/ChangeLog:12 > + Make the outer switch a function to be called window.onload, and stop to >> Make the outer switch a function to be called window.onload Is this necessary to fix the failure? (Why?) Or is this just a refactoring? (In reply to comment #4) > > LayoutTests/ChangeLog:12 > > + Make the outer switch a function to be called window.onload, and stop to > > >> Make the outer switch a function to be called window.onload > > Is this necessary to fix the failure? (Why?) Or is this just a refactoring? Yes. ChangeLog explains the reason at the previous paragraph. Comment on attachment 176922 [details]
Patch
Makes sense. (I was misreading js-test-post.js with js-test-pre.js.)
Created attachment 176927 [details]
Patch for landing
Fix summary
Comment on attachment 176927 [details] Patch for landing Clearing flags on attachment: 176927 Committed r136219: <http://trac.webkit.org/changeset/136219> All reviewed patches have been landed. Closing bug. r136219 fixed the major flakiness. However they still timed out and I marked them [ Slow ] in http://trac.webkit.org/changeset/136333 . The slowness should be addressed in Bug 104094. |